New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move methods to the end of the route declaration #17

Merged

TalRoni merged 1 commit into TalRoni:main from rluvaton:change-route-method-to-end

Aug 5, 2024

Contributor

rluvaton commented Aug 4, 2024 •

edited

Loading

This is done to avoid bugs like:

Not found error translate to method not allowed when there is route with method is at the start of the route seanmonstar/warp#1104


          move methods to the end of the route declaration

98371b8

TalRoni approved these changes

View reviewed changes

Contributor Author

rluvaton commented Aug 5, 2024

Can we merge this and the other PR?

TalRoni merged commit 662912d into TalRoni:main

1 check passed

rluvaton deleted the change-route-method-to-end branch

August 5, 2024 18:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet