fix(TCOMP-2710): fix sonar warnings

Talend · Jun 25, 2024 · b9e8d63 · b9e8d63
1 parent ba2d0cd
commit b9e8d63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ntime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java b/...ntime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java
@@ -204,7 +204,7 @@ public void guessComponentSchema(final Schema incomingSchema, final String outgo
         } catch (Exception e) {
             final DiscoverSchemaException dse = transformException(e);
             // When a processor is the start of a studio job and dev explicitly set the handleError to Lifecycle exec
-            if (isStartOfJob && EXECUTE_LIFECYCLE.equals(dse.getPossibleHandleErrorWith())) {
+            if (isStartOfJob && EXECUTE_LIFECYCLE == dse.getPossibleHandleErrorWith()) {
                 try {
                     guessOutputComponentSchemaThroughResult();
                 } catch (Exception er) {

diff --git a/...e-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java b/...e-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java
@@ -17,6 +17,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -504,12 +505,12 @@ void deserializeDiscoverSchemaException() throws Exception {
         final String serialized =
                 "{\"localizedMessage\":\"Unknown error. Retry!\",\"message\":\"Unknown error. Retry!\",\"stackTrace\":[],\"suppressed\":[],\"possibleHandleErrorWith\":\"RETRY\"}";
         DiscoverSchemaException e = jsonToException(flattened);
-        assertFalse("EXECUTE_MOCK_JOB".equals(e.getPossibleHandleErrorWith().name()));
+        assertNotEquals("EXECUTE_MOCK_JOB", e.getPossibleHandleErrorWith().name());
         assertEquals("EXCEPTION", e.getPossibleHandleErrorWith().name());
         assertEquals("Not allowed to execute the HTTP call to retrieve the schema.", e.getMessage());
         //
         e = jsonToException(serialized);
-        assertFalse("EXCEPTION".equals(e.getPossibleHandleErrorWith()));
+        assertNotEquals("EXCEPTION", e.getPossibleHandleErrorWith());
         assertEquals("RETRY", e.getPossibleHandleErrorWith().name());
         assertEquals("Unknown error. Retry!", e.getMessage());
     }