feat(TCOMP-2554): Restore extraBuildParams in release script #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
undx
reviewed
Oct 25, 2023
Comment on lines
+28
to
+29
|
|
||
|
|
There was a problem hiding this comment.
It was to add space between parameters vars and others vars
undx
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore extraBuildParams in release script
https://jira.talendforge.org/browse/TCOMP-2554
Why this PR is needed?
The CI was using env var to pass args to the release script.
After CI evolution this env var was not accessible anymore, this PR restore the functionality using script parameter instead of env var.
What does this PR adds (design/code thoughts)?
Add parameter to release.sh