Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TCOMP-2565): support origin type pass for studio dynamic type #822

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

wwang-talend
Copy link
Contributor

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

https://jira.talendforge.org/browse/TCOMP-2565

What does this PR adds (design/code thoughts)?

https://jira.talendforge.org/browse/TCOMP-2565

Copy link

sonar-eks bot commented Nov 21, 2023

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 85.71% Coverage (54.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.40% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acatoire
Copy link
Contributor

acatoire commented Dec 5, 2023

The PR is adding a sonar code smell, is it possible to fix it before merge?

@wwang-talend
Copy link
Contributor Author

sonar think too many assert in one test unit method, it exists before already, here only add a new one. We can adjust it in a new workitem, here focus on current issue.

@wwang-talend wwang-talend merged commit 367d4af into master Dec 14, 2023
5 of 6 checks passed
@wwang-talend wwang-talend deleted the wwang-talend/TCOMP-2565-dynamic-origintype branch December 14, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants