Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TCOMP-2573): null value configuration accepted #823

Conversation

ozhelezniak-talend
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend commented Nov 22, 2023

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

https://jira.talendforge.org/browse/TCOMP-2573

What does this PR adds (design/code thoughts)?

This comment has been minimized.

This comment has been minimized.

Copy link

sonar-eks bot commented Dec 2, 2023

Failed

  • C Maintainability Rating on New Code (is worse than A)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 80.95% Coverage (54.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.40% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

@undx
Copy link
Member

undx commented Dec 28, 2023

Fix will be done in a studio integration pull-request.

@undx undx closed this Dec 28, 2023
@undx undx deleted the ozhelezniak/TCOMP-2573-nullvalue-configuration branch December 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants