-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TCOMP-2744): add @ReadOnly annotation #897
base: master
Are you sure you want to change the base?
Conversation
Analysis Details1 IssueCoverage and DuplicationsProject ID: org.talend.sdk.component:component-runtime |
@@ -172,6 +172,9 @@ protected UiSchema newOrphanSchema(final PropertyContext<?> ctx) { | |||
if (Boolean.parseBoolean(ctx.getProperty().getMetadata().getOrDefault("documentation::tooltip", "false"))) { | |||
schema.setTooltip(ctx.getProperty().getMetadata().get("documentation::value")); | |||
} | |||
if (Boolean.parseBoolean(ctx.getProperty().getMetadata().getOrDefault("ui::readonly", "false"))) { | |||
schema.setReadOnly(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, we had this property???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in the UiSchema specification so already existed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://jira.talendforge.org/browse/TCOMP-2744