-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TCOMP-2739):Create an action validator for the @DynamicDependencies annotation #901
feat(TCOMP-2739):Create an action validator for the @DynamicDependencies annotation #901
Conversation
This comment has been minimized.
This comment has been minimized.
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some stuff are missing
The action should certainly be added here also
Line 182 in 5ab148c
Suggestions.class, Update.class); |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also sonar lint comments and fix them.
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java
Outdated
Show resolved
Hide resolved
component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java
Outdated
Show resolved
Hide resolved
component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java
Outdated
Show resolved
Hide resolved
component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minors comments
component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java
Outdated
Show resolved
Hide resolved
component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java
Outdated
Show resolved
Hide resolved
Analysis Details0 IssuesCoverage and DuplicationsProject ID: org.talend.sdk.component:component-runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
https://jira.talendforge.org/browse/TCOMP-2739
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?