Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(TCOMP-2707): correct workflow and exception throwing" #906

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Revert "fix(TCOMP-2707): correct workflow and exception throwing" #906

merged 1 commit into from
Jul 1, 2024

Conversation

undx
Copy link
Member

@undx undx commented Jul 1, 2024 •
edited
Loading

Reverts #888
Superseded by #902

@sonar-eks sonar-eks
Copy link

sonar-eks bot commented Jul 1, 2024

Failed

  • B Maintainability Rating on New Code (is worse than A)
  • 65.38% Coverage on New Code (is less than 80.00%)

Analysis Details

7 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 7 Code Smells

Coverage and Duplications

  • Coverage 65.38% Coverage (54.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (1.30% Estimated after merge)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

ozhelezniak-talend
ozhelezniak-talend approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ozhelezniak-talend ozhelezniak-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@undx undx merged commit 9cf3b1f into master Jul 1, 2024
5 of 6 checks passed
@undx undx deleted the revert-888-undx/TCOMP-2707-guess-schema-exception branch July 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozhelezniak-talend ozhelezniak-talend ozhelezniak-talend approved these changes

@acatoire acatoire Awaiting requested review from acatoire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@undx @ozhelezniak-talend