feat: implement fee calculation and splitting logic for escrow contract#134
Merged
mikewheeleer merged 2 commits intoTalenttrust:mainfrom Apr 1, 2026
Merged
Conversation
|
@winnpxl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
winnpxl
force-pushed
the
feature/contracts-44-fee-accounting-tests
branch
3 times, most recently
from
66c84c0 to
180518f
Compare
Contributor
|
@winnpxl Resolve the conflicts |
- Add FeeConfig, FeeRecipient, FeeSplit, and Treasury data structures - Implement calculate_fee() with floor rounding strategy - Implement split_fee() with primary recipient remainder handling - Implement update_treasury() for fee accumulation - Add comprehensive tests for fee splitting scenarios (4 tests) - All tests passing (20 contract tests + 2 additional tests) - Support multiple fee authorization schemes (client-only, arbiter-only, multi-sig) - Resolved conflicts with upstream/main
winnpxl
force-pushed
the
feature/contracts-44-fee-accounting-tests
branch
from
277decb to
ff0e60f
Compare
Contributor
Author
|
conflicts resolved @mikewheeleer , kindly merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Fee calculation and splitting for escrow contract
Closes #94
Description:
Changes
Testing
Verification
cargo +nightly checkpassescargo +nightly test --all-featurespasses