feat(escrow): event contract tests with 98.51% coverage#144
Open
TYDev01 wants to merge 6 commits intoTalenttrust:mainfrom
Open
feat(escrow): event contract tests with 98.51% coverage#144TYDev01 wants to merge 6 commits intoTalenttrust:mainfrom
TYDev01 wants to merge 6 commits intoTalenttrust:mainfrom
Conversation
- Rewrote lib.rs with clean implementation and 14 structured events - Added test/events.rs: tests covering all event types, payload correctness, ordering, absence guarantees, and accumulation - Fixed all 10 existing test modules to align with updated API - Added docs/escrow/events.md: full event catalogue with decode examples - Updated README.md with event quick-reference table
|
@TYDev01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@TYDev01 please resolve the conflicts |
- Accepted HEAD (feature branch) for lib.rs, test.rs, flows.rs, security.rs, lifecycle.rs, and snapshot JSON files to preserve the clean event-driven implementation and 98.51% test coverage - Merged both branches' README.md test-command and Upgradeable Storage Planning sections, combining event-contract doc pointers with storage/ access-control pointers from main - Fixed lifecycle.rs which was committed to origin/main with stale conflict markers from feature/contracts-27-contract-ownership-transfer All 81 tests pass.
Author
|
Hello Chief, can you check. |
Contributor
|
@TYDev01 Please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #90