feat: implement protocol parameter governance and threat model with c…

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "kiroAgent.configureMCP": "Disabled"
+}

contracts/escrow/src/lib.rs

@@ -123,6 +123,9 @@ pub struct MainnetReadinessInfo {
 #[contracttype]
 #[derive(Clone)]
 enum DataKey {
+    Admin,
+    Paused,
+    EmergencyPaused,
     NextContractId,
     Contract(u32),
     Reputation(Address),

contracts/escrow/src/test/governance.rs

@@ -30,31 +30,61 @@ fn governance_initialization_and_updates_change_live_validation_rules() {
     let client = register_client(&env);
 
     let admin = Address::generate(&env);
-    assert!(client.initialize_protocol_governance(&admin, &50_i128, &2_u32, &2_i128, &4_i128));
+    assert!(client.initialize_governance(&admin));
+
+    assert_eq!(client.get_governance_admin(), Some(admin));
+    assert_eq!(client.get_pending_governance_admin(), None);
+}
+
+#[test]
+#[should_panic(expected = "protocol governance is already initialized")]
+fn initialize_governance_twice_panics() {
+    let (env, contract_id) = setup();
+    let client = EscrowClient::new(&env, &contract_id);
+
+    let admin = Address::generate(&env);
+    client.initialize_governance(&admin);
+
+    // Second initialization should panic
+    let admin2 = Address::generate(&env);
+    client.initialize_governance(&admin2);
+}
+
+#[test]
+fn update_protocol_parameters_changes_validation_rules() {
+    let (env, contract_id) = setup();
+    let client = EscrowClient::new(&env, &contract_id);
+
+    let admin = Address::generate(&env);
+    client.initialize_governance(&admin);
+
+    assert!(client.update_protocol_parameters(&100_i128, &10_u32, &1_i128, &10_i128));
 
     let parameters = client.get_protocol_parameters();
-    assert_eq!(
-        parameters,
-        ProtocolParameters {
-            min_milestone_amount: 50,
-            max_milestones: 2,
-            min_reputation_rating: 2,
-            max_reputation_rating: 4,
-        }
-    );
-    assert_eq!(client.get_governance_admin(), Some(admin.clone()));
+    assert_eq!(parameters.min_milestone_amount, 100);
+    assert_eq!(parameters.max_milestones, 10);
+    assert_eq!(parameters.min_reputation_rating, 1);
+    assert_eq!(parameters.max_reputation_rating, 10);
+}
+
+#[test]
+#[should_panic(expected = "protocol governance is not initialized")]
+fn update_protocol_parameters_without_initialization_panics() {
+    let (env, contract_id) = setup();
+    let client = EscrowClient::new(&env, &contract_id);
 
-    assert!(client.update_protocol_parameters(&75_i128, &3_u32, &1_i128, &5_i128));
+    // Try to update without initializing governance
+    client.update_protocol_parameters(&100_i128, &10_u32, &1_i128, &10_i128);
+}
 
-    let updated = client.get_protocol_parameters();
-    assert_eq!(updated.min_milestone_amount, 75);
-    assert_eq!(updated.max_milestones, 3);
-    assert_eq!(updated.min_reputation_rating, 1);
-    assert_eq!(updated.max_reputation_rating, 5);
+#[test]
+#[should_panic(expected = "minimum milestone amount must be positive")]
+fn update_protocol_parameters_with_zero_min_milestone_panics() {
+    let (env, contract_id) = setup();
+    let client = EscrowClient::new(&env, &contract_id);
 
-    let escrow_client = Address::generate(&env);
-    let freelancer = Address::generate(&env);
-    let milestones = vec![&env, 75_i128, 90_i128, 120_i128];
+    let admin = Address::generate(&env);
+    client.initialize_governance(&admin);
 
     let contract_id = client.create_contract(&escrow_client, &freelancer, &milestones);
     assert!(client.deposit_funds(&contract_id, &285_i128));

docs/escrow/README.md

@@ -100,6 +100,8 @@ Operational invariants:
 
 ## Incident Response
 
+### Emergency Response
+
 1. Detect incident and call `activate_emergency_pause`.
 2. Investigate and remediate root cause.
 3. Validate mitigations in test/staging.