-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintainance/docker dev env #32
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good addition, but we need to document how to use it, perhaps in the README.
As a side note, I can successfully build the production image by specifying the platform:
docker build --platform linux/amd64 .
"customizations": { | ||
"vscode": {} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: What does this customization do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a placeholder for vscode plugins .... can be removed
Nontheless, the whole impact of this PR is reduced by #35
@@ -0,0 +1,8 @@ | |||
|
|||
FROM --platform=linux/amd64 ghcr.io/talusbio/nf-encyclopedia:latest | |||
RUN apt update && apt install default-jdk-headless git docker -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Have you tried used the version of the JRE that is installed in the production image?
We build on top of the official EncyclopeDIA image, which uses the openjdk:8-jre as their base image. I don't know if the JRE version will work with NextFlow, but it might be worth checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the EncyclopeDIA Dockerfile: https://bitbucket.org/searleb/encyclopedia/src/master/Dockerfile
Is this PR still needed with #35? |
I really like the concept of this pr but ... since right now I am experiencing a weird issue where the tests occasionally stall. Which I believe could be somehow related to the way that nextflow detects that a spawned process has finished, which might be weird when running docker inside groovy inside python inside docker .... So it think we can leave this in the back burner for a while and just document the patch for MSSTATS on mac. |
Adds docker container for usage in development.
Why?
Specification for dev containers:
https://containers.dev/overview