Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our docker image, linting, and GH actions #7

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

wfondrie
Copy link
Member

@wfondrie wfondrie commented Jun 26, 2024

This PR migrates to a uv-based multi-stage docker build. It also improves our GH actions workflows and moves fully to Ruff.

Note that the linting action fails now, but I did not want to create a large PR here. I propose a linting fix as a second PR, with only formatting changes.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.20%. Comparing base (40dfebd) to head (b5d8a22).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files           8        8           
  Lines         250      250           
=======================================
  Hits          108      108           
  Misses        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wfondrie wfondrie requested review from jspaezp June 26, 2024 21:06
@wfondrie wfondrie mentioned this pull request Jun 26, 2024
Copy link

@jspaezp jspaezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions but LGTM

Dockerfile Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@wfondrie wfondrie merged commit 3713d2d into main Jul 2, 2024
8 of 9 checks passed
@wfondrie wfondrie deleted the docker-update branch July 2, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants