Fix: don't purge Direct Writes (Query Collection) when query results change #808
+131
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where items inserted via Direct Writes (writeInsert/writeUpsert) were incorrectly purged when query results changed and didn't include those items. **Root Cause:** The reference counting system (queryToRows/rowToQueries) tracks which items are in each query result. When a query result doesn't include an item and the item's reference count is 0, it gets deleted. Direct Write items were never added to this tracking system, so they always had a reference count of 0 and were purged when not in query results. **Solution:** - Added `directWriteKeys` Set to track items inserted via Direct Writes - Modified purging logic in `handleQueryResult()` and `cleanupQuery()` to skip items in the `directWriteKeys` Set - Updated `performWriteOperations()` to add/remove keys from `directWriteKeys`: - Insert operations add the key - Delete operations remove the key - Upsert operations add the key if inserting new item **Changes:** - query.ts: Added directWriteKeys Set and modified purging checks - manual-sync.ts: Track direct write keys in performWriteOperations - query.test.ts: Added test case to verify Direct Writes are protected This ensures directly-written items persist until explicitly deleted via writeDelete(), regardless of query result changes.
🦋 Changeset detectedLatest commit: 1765904 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 86 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.34 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where items inserted via Direct Writes (writeInsert/writeUpsert) were incorrectly purged when query results changed and didn't include those items.
Root Cause:
The reference counting system (queryToRows/rowToQueries) tracks which items are in each query result. When a query result doesn't include an item and the item's reference count is 0, it gets deleted. Direct Write items were never added to this tracking system, so they always had a reference count of 0 and were purged when not in query results.
Solution:
directWriteKeysSet to track items inserted via Direct WriteshandleQueryResult()andcleanupQuery()to skip items in thedirectWriteKeysSetperformWriteOperations()to add/remove keys fromdirectWriteKeys:Changes:
This ensures directly-written items persist until explicitly deleted via writeDelete(), regardless of query result changes.
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact