Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): eslint-plugin-query now working with vanilla js #8322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShyneADL
Copy link

To fix the issue with detecting imports in both TypeScript and JavaScript files, I modify the ImportDeclaration handler to handle cases where importKind might be undefined.

The key change is adding node.importKind === undefined to the condition. This ensures the import detection works for both TypeScript (where importKind is explicitly 'value') and JavaScript (where importKind is undefined).

This modification should resolve the lint plugin's compatibility issue with vanilla JavaScript apps by allowing import detection regardless of the importKind value.

closes #8257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-query not working with vanilla JS
1 participant