Skip to content

fix(query-core): fix combine not updating when queries change with stable reference #9954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 6 commits into from
Jan 16, 2026
+191 −1

Merge branch 'main' into fix/combine-bug

291afec
Select commit
Loading
Failed to load commit list.
Merged

fix(query-core): fix combine not updating when queries change with stable reference #9954

Merge branch 'main' into fix/combine-bug
291afec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 5, 2026 in 1s

59.83% (+14.00%) compared to f616474

View this Pull Request on Codecov

59.83% (+14.00%) compared to f616474

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.83%. Comparing base (f616474) to head (291afec).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9954       +/-   ##
===========================================
+ Coverage   45.82%   59.83%   +14.00%     
===========================================
  Files         200      129       -71     
  Lines        8525     5749     -2776     
  Branches     1977     1581      -396     
===========================================
- Hits         3907     3440      -467     
+ Misses       4158     1994     -2164     
+ Partials      460      315      -145
Components Coverage Δ
@tanstack/angular-query-experimental 93.85% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 97.88% <100.00%> (+0.50%) ⬆️
@tanstack/query-devtools 3.38% <ø> (ø)
@tanstack/query-persist-client-core 80.00% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 96.40% <ø> (ø)
@tanstack/react-query-devtools 9.25% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 77.81% <ø> (ø)
@tanstack/solid-query-devtools 64.17% <ø> (ø)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query 71.91% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov