Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(react-router): improve resolve relative route and use intersections for checking path #2425

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chorobin
Copy link
Contributor

@chorobin chorobin commented Sep 26, 2024

Decreasing overall check time and instantiations.

Before:

> tsc --extendedDiagnostics

Files:                         683
Lines of Library:            41276
Lines of Definitions:        86334
Lines of TypeScript:         24509
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                144211
Symbols:                    387083
Types:                      114916
Instantiations:             738510
Memory used:               394499K
Assignability cache size:    45732
Identity cache size:          8525
Subtype cache size:          44038
Strict subtype cache size:      10
I/O Read time:               0.10s
Parse time:                  0.59s
ResolveModule time:          0.19s
ResolveTypeReference time:   0.00s
ResolveLibrary time:         0.03s
Program time:                1.05s
Bind time:                   0.31s
Check time:                  5.88s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                  7.24s

After:

> tsc --extendedDiagnostics

Files:                         679
Lines of Library:            41276
Lines of Definitions:        83242
Lines of TypeScript:         24485
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                140221
Symbols:                    370974
Types:                      113612
Instantiations:             695636
Memory used:               398422K
Assignability cache size:    41080
Identity cache size:          8525
Subtype cache size:          45560
Strict subtype cache size:      17
I/O Read time:               0.09s
Parse time:                  0.57s
ResolveModule time:          0.17s
ResolveTypeReference time:   0.00s
ResolveLibrary time:         0.02s
Program time:                0.97s
Bind time:                   0.35s
Check time:                  5.47s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                  6.79s

Copy link

nx-cloud bot commented Sep 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 90356a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Sep 26, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2425

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2425

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2425

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2425

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2425

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2425

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2425

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2425

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2425

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2425

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2425

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2425

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2425

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2425

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2425

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2425

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2425

commit: 90356a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant