fix(react-router): loader promise not resolving when error thrown in params.parse
#2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to TanStack#2514 Add test to verify `notFoundComponent` is displayed when an error is thrown in `params.parse` in a child route. * Add a new test case in `errorComponent.test.tsx` to check if the `notFoundComponent` is rendered when an error is thrown in `params.parse`. * Create a root route with a `notFoundComponent`. * Create an index route with a link to a child route. * Create a child route with a `params.parse` function that throws an error for a specific condition and an `onError` function that re-throws the error as `notFound()`. * Render the router and simulate a click on the link to the child route. * Verify that the `notFoundComponent` is displayed.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4050e58. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
is this testing the same thing as #2636 ? |
SeanCassiere
changed the title
params.parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2514
Add test to verify
notFoundComponentis displayed when an error is thrown inparams.parsein a child route.errorComponent.test.tsxto check if thenotFoundComponentis rendered when an error is thrown inparams.parse.notFoundComponent.params.parsefunction that throws an error for a specific condition and anonErrorfunction that re-throws the error asnotFound().notFoundComponentis displayed.