Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(start): checking if the bound server fn URL is hardcoded #2787

Closed
wants to merge 3 commits into from

Conversation

SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Nov 17, 2024

E2E Test for #2720

Copy link

nx-cloud bot commented Nov 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4d9819a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 17, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/arktype-adapter@2787

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2787

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2787

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2787

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2787

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2787

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2787

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2787

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2787

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2787

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2787

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2787

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2787

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2787

@tanstack/valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-adapter@2787

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2787

@tanstack/zod-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-adapter@2787

commit: 4d9819a

@SeanCassiere SeanCassiere marked this pull request as ready for review November 17, 2024 10:06
@SeanCassiere
Copy link
Member Author

This test is no longer needed since 56fae6a resolves this issue and only rendering the localhost origin on the client-side (with the correct host).

@SeanCassiere SeanCassiere deleted the test/2770-base-url-should-not-be-hardcoded branch November 22, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant