-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: router should have 'pending' when loaders in progress (draft) #2790
Open
lislon
wants to merge
4
commits into
TanStack:main
Choose a base branch
from
lislon:router-should-show-pending-when-loaders-in-progress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: router should have 'pending' when loaders in progress (draft) #2790
lislon
wants to merge
4
commits into
TanStack:main
from
lislon:router-should-show-pending-when-loaders-in-progress
+71
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 85c5502. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
lislon
force-pushed
the
router-should-show-pending-when-loaders-in-progress
branch
from
November 17, 2024 20:25
8f21dad
to
17c459c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
router
had a stateidle
, while theload
andbeforeLoad
was not resolved.I noticed this in tests, when I attempted to fix the warning
by waiting for
state = idle
.I also noticed that
Transitionier
warning happens inafterEach
, so I've added a unsubscribe method for history:Should I expand this approach for other tests?