-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: switch to tinyglobby #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughReplaces fast-glob with tinyglobby in router-utils: updates package.json dependency and switches the import and usage in copy-files-plugin.ts to use tinyglobby’s glob function. No API or behavior changes beyond the library swap. Changes
Sequence Diagram(s)sequenceDiagram
participant Build as Build Tool
participant Plugin as CopyFilesPlugin
participant Glob as tinyglobby.glob
participant FS as File System
Build->>Plugin: run(patterns, fromDir, toDir)
Plugin->>Glob: glob(patterns, { cwd: fromDir })
Glob-->>Plugin: entries[]
alt no entries
Plugin-->>Build: throw Error("No files matched")
else entries found
loop for each entry
Plugin->>FS: ensureDir(toDir/<entryDir>)
Plugin->>FS: copy(fromDir/<entry>, toDir/<entry>)
end
Plugin-->>Build: done
end
Note over Plugin,Glob: Glob provider changed from fast-glob to tinyglobby
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (2)**/package.json📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
View your CI Pipeline Execution ↗ for commit caa194c
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
fast-glob
has 17 dependencies compared to just two fortinyglobby
Vite uses
tinyglobby
so it's already in the dependency tree. nitropack v3 does as well, so once the upgrade to the latest nitropack happens, tanstack will be fully ontinyglobby
Summary by CodeRabbit
New Features
Refactor
Chores
Documentation
Tests