fix(selection): update logic to fix selection of disabled rows #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2jordan3
reviewed
May 28, 2024
Comment on lines
+447
to
+458
| const getIsSomeSelectedByCondition = () => { | ||
| return ignoreCanSelect | ||
| ? paginationFlatRows.some( | ||
| d => d.getIsSelected() || d.getIsSomeSelected() | ||
| ) && | ||
| paginationFlatRows.some( | ||
| d => !d.getIsSelected() || !d.getIsSomeSelected() | ||
| ) | ||
| : paginationFlatRows | ||
| .filter(row => row.getCanSelect()) | ||
| .some(d => d.getIsSelected() || d.getIsSomeSelected()) | ||
| } |
There was a problem hiding this comment.
I think the readability is still lacking.
How about separating this part into an independent function or clearly splitting it with if-else statements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue:
#5398
We updated logic for selection of disabled rows (at least for pagination).
Here next possible flows:
Status of all enabled checkboxes always will be toggled, but sign inside Footer checkbox will show real state of all checkboxes
P.S. Also
getToggleAllRowsSelectedHandlerrespect disabled checkboxes