fix: replace typeof window checks with typeof document (#516)

TanStack · Feb 26, 2023 · bc16c19 · bc16c19
1 parent 9712ef5
commit bc16c19
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/packages/react-virtual/src/index.tsx b/packages/react-virtual/src/index.tsx
@@ -15,7 +15,7 @@ export * from '@tanstack/virtual-core'
 //
 
 const useIsomorphicLayoutEffect =
-  typeof window !== 'undefined' ? React.useLayoutEffect : React.useEffect
+  typeof document !== 'undefined' ? React.useLayoutEffect : React.useEffect
 
 function useVirtualizerBase<
   TScrollElement extends Element | Window,
@@ -77,7 +77,7 @@ export function useWindowVirtualizer<TItemElement extends Element>(
   >,
 ): Virtualizer<Window, TItemElement> {
   return useVirtualizerBase<Window, TItemElement>({
-    getScrollElement: () => (typeof window !== 'undefined' ? window : null!),
+    getScrollElement: () => (typeof document !== 'undefined' ? window : null!),
     observeElementRect: observeWindowRect,
     observeElementOffset: observeWindowOffset,
     scrollToFn: windowScroll,

diff --git a/packages/solid-virtual/src/index.tsx b/packages/solid-virtual/src/index.tsx
@@ -118,7 +118,7 @@ export function createWindowVirtualizer<TItemElement extends Element>(
     mergeProps(
       {
         getScrollElement: () =>
-          typeof window !== 'undefined' ? window : null!,
+          typeof document !== 'undefined' ? window : null!,
         observeElementRect: observeWindowRect,
         observeElementOffset: observeWindowOffset,
         scrollToFn: windowScroll,

diff --git a/packages/svelte-virtual/src/index.ts b/packages/svelte-virtual/src/index.ts
@@ -88,7 +88,7 @@ export function createWindowVirtualizer<TItemElement extends Element>(
   >,
 ): Readable<SvelteVirtualizer<Window, TItemElement>> {
   return createVirtualizerBase<Window, TItemElement>({
-    getScrollElement: () => (typeof window !== 'undefined' ? window : null!),
+    getScrollElement: () => (typeof document !== 'undefined' ? window : null!),
     observeElementRect: observeWindowRect,
     observeElementOffset: observeWindowOffset,
     scrollToFn: windowScroll,

diff --git a/packages/vue-virtual/src/index.ts b/packages/vue-virtual/src/index.ts
@@ -103,7 +103,8 @@ export function useWindowVirtualizer<TItemElement extends Element>(
   return useVirtualizerBase<Window, TItemElement>(
     computed(() => ({
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      getScrollElement: () => (typeof Window !== 'undefined' ? window : null!),
+      getScrollElement: () =>
+        typeof document !== 'undefined' ? window : null!,
       observeElementRect: observeWindowRect,
       observeElementOffset: observeWindowOffset,
       scrollToFn: windowScroll,