[NPE-5] Address Singleton #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojameso
force-pushed
the
npe-5/address_singleton
branch
from
8b1a59e to
04250df
Compare
captainkevron
approved these changes
Apr 27, 2023
obrie
reviewed
May 10, 2023
| def singleton_safe_marshal(value) | ||
| # Rspec mocks create singletons out of objects in order to track calls | ||
| # However, singletons can't be dumped, so skip marshaling | ||
| return value if value.singleton_methods.any? |
There was a problem hiding this comment.
We might need to be careful here -- while Object defines singleton_methods, its superclass (BasicObject) doesn't. We could consider doing a defined?(value.singleton_methods) here.
Alternatively, can we check for the mock class? (i.e. is there a way to remain aware of integration issues while still avoiding the rspec mock issues)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.2 has singleton issues that break specs. Adding escape for errors raised by these singletons.
Confirmed that this passes specs in Rails 5.2.
NOTE: If we happen to write code that passes singleton objects as values, we will not see the error captured in specs.