Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancements] Streaming option + Query Parameters #11

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

intellitour
Copy link

Hi there!

In my app, I needed these enhancements: stream data directly (instead of multipart) and (due to API characteristics) query parameters support. So... I decided to share those with the community.

Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I left some comments. Please take a look.

.fvmrc Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with FVM. Is setting up FVM in the plugin necessary for projects using FVM to use this plugin?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No... just something to ease our developer lives when dealing with multiple projects that use multiple Flutter versions.

Setting up FVM is not necessary for anyone. Setting up will help those in the situation I've mentioned. Those who do not want to use it, will not be punished.

@intellitour
Copy link
Author

@Amir-P change request fulfilled.

@intellitour
Copy link
Author

@Amir-P I had some commits pending push. Now everything is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants