fix: issue with player profiles without title ingame (#73)

TeKrop · Nov 1, 2023 · 6ea8315 · 6ea8315
1 parent 6a2f92d
commit 6ea8315
Show file tree

Hide file tree

Showing 6 changed files with 13,462 additions and 5 deletions.
diff --git a/app/common/helpers.py b/app/common/helpers.py
@@ -41,6 +41,7 @@
     "Player-137712",  # Private profile
     "TeKrop-2217",  # Classic profile
     "Unknown-1234",  # No player
+    "JohnV1-1190",  # Player without any title ingame
 ]
 
 # httpx client settings

diff --git a/app/parsers/player_parser.py b/app/parsers/player_parser.py
@@ -122,6 +122,7 @@ def __get_summary(self) -> dict:
             class_="Profile-player--info",
             recursive=False,
         )
+
         return {
             "username": (
                 summary_div.find("h1", class_="Profile-player--name").get_text()
@@ -141,14 +142,18 @@ def __get_summary(self) -> dict:
 
     @staticmethod
     def __get_title(profile_div: Tag) -> str | None:
-        title = (
-            profile_div.find(
+        # We return None is there isn't any player title div
+        if not (
+            title_tag := profile_div.find(
                 "h2",
                 class_="Profile-player--title",
                 recursive=False,
-            ).get_text()
-            or None
-        )
+            )
+        ):
+            return None
+
+        # Retrieve the title text
+        title = title_tag.get_text() or None
 
         # Special case : the "no title" means there is no title
         return None if title and title.lower() == "no title" else title

diff --git a/tests/fixtures/html/players/JohnV1-1190.html b/tests/fixtures/html/players/JohnV1-1190.html