Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new clash mode and associated maps #192

Closed
navalex opened this issue Sep 12, 2024 · 2 comments · Fixed by #193
Closed

Adding new clash mode and associated maps #192

navalex opened this issue Sep 12, 2024 · 2 comments · Fixed by #193
Assignees
Labels
enhancement New feature or request

Comments

@navalex
Copy link

navalex commented Sep 12, 2024

Hello,

I was making some changes on my website to allow printing informations about the new features of the game, and I discovered that the API does not yet have integrated the new gamemode.

If it's only a change in the maps.csv I can probably make a PR, but I don't know if adding a new gamemode in the CSV will or not break something in the API.

Hope you'll understand,

And many thanks for your work it's amazing !

@navalex navalex added the enhancement New feature or request label Sep 12, 2024
@TeKrop
Copy link
Owner

TeKrop commented Sep 12, 2024

Hello,

I also have to update the gamemodes.csv file, existing because sometimes Blizzard takes some time to update their landing page with the new gamemode. I'll also add the icon and the preview picture.

For now, some test fixtures will also need to be updated. I'm currently making a refactoring on another branch to avoid this in the future, and make updates easier without reducing tests relevance and accuracy.

I'm handling it and I'll keep you updated 👍

@TeKrop TeKrop linked a pull request Sep 12, 2024 that will close this issue
@TeKrop
Copy link
Owner

TeKrop commented Sep 12, 2024

Added in last release ✅ Let me know if everything is working fine for you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants