Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added clash mode and associated maps #193

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Sep 12, 2024

Summary by Sourcery

Add a new 'Clash' game mode with corresponding maps and update the test suite to validate the inclusion of this new mode.

New Features:

  • Introduce a new game mode called 'Clash' with associated maps 'Hanaoka' and 'Throne of Anubis'.

Enhancements:

  • Update the maps JSON fixture to include the new 'Clash' game mode and its associated maps.

Tests:

  • Modify test cases to include validation for the new 'Clash' game mode in the maps route.

@TeKrop TeKrop added the enhancement New feature or request label Sep 12, 2024
@TeKrop TeKrop self-assigned this Sep 12, 2024
@TeKrop TeKrop linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Contributor

sourcery-ai bot commented Sep 12, 2024

Reviewer's Guide by Sourcery

This pull request adds a new game mode called "Clash" and introduces two new maps associated with it. The changes are implemented by updating the JSON data for maps and game modes, as well as modifying a test file to include the new game mode in the valid options.

File-Level Changes

Change Details Files
Added new game mode 'Clash' to the gamemodes.json file
  • Inserted a new JSON object for the 'Clash' game mode
  • Added key, name, icon, description, and screenshot for the new game mode
tests/fixtures/json/gamemodes.json
Updated maps.json to include new maps for the 'Clash' game mode
  • Added 'Hanaoka' map located in Tokyo, Japan
  • Added 'Throne of Anubis' map located in Giza Plateau, Egypt
  • Both new maps are associated with the 'clash' game mode
tests/fixtures/json/maps.json
Updated test file to include 'clash' as a valid game mode option
  • Modified the error message in the test to include 'clash' in the list of valid game modes
tests/views/test_maps_route.py
Reformatted maps.json for improved readability
  • Changed the JSON structure from a single line to a more readable multi-line format
tests/fixtures/json/maps.json

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/views/test_maps_route.py Show resolved Hide resolved
@TeKrop TeKrop merged commit 95e23fc into main Sep 12, 2024
3 checks passed
@TeKrop TeKrop deleted the 192-adding-new-clash-mode-and-associated-maps branch September 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new clash mode and associated maps
1 participant