Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issue with roles endpoint since Blizzard update #145

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Jun 23, 2024

Summary by Sourcery

This pull request addresses a bug in the roles endpoint parser caused by recent updates to Blizzard's HTML structure. The HTML fixture for the home page has been updated to match the new structure, ensuring accurate parsing of roles data.

  • Bug Fixes:
    • Fixed issue with roles endpoint parsing due to changes in Blizzard's HTML structure.
  • Tests:
    • Updated HTML fixture for home page to reflect changes in Blizzard's HTML structure.

@TeKrop TeKrop added the bug Something isn't working label Jun 23, 2024
@TeKrop TeKrop self-assigned this Jun 23, 2024
Copy link
Contributor

sourcery-ai bot commented Jun 23, 2024

Reviewer's Guide by Sourcery

This pull request addresses the issue with the roles endpoint caused by Blizzard's recent update. The changes include updating the HTML structure in the test fixtures and simplifying the parsing logic in the roles parser to accommodate the new structure.

File-Level Changes

Files Changes
tests/fixtures/html/home.html
app/parsers/roles_parser.py
Updated HTML structure and parsing logic to align with Blizzard's recent changes to the roles endpoint.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

sonarcloud bot commented Jun 23, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

app/parsers/roles_parser.py Show resolved Hide resolved
app/parsers/roles_parser.py Show resolved Hide resolved
@TeKrop TeKrop merged commit e6fd7b8 into main Jun 23, 2024
3 checks passed
@TeKrop TeKrop deleted the bugfix/roles-page-error branch June 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant