Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Runasapi to maps and test #149

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat: add Runasapi to maps and test #149

merged 2 commits into from
Jul 1, 2024

Conversation

Mascherino
Copy link
Contributor

@Mascherino Mascherino commented Jun 30, 2024

Adds the new Runasapi map to the maps csv and the corresponding test.

Summary by Sourcery

This pull request introduces the 'Runasapi' map to the existing maps JSON file and adds a corresponding test to ensure its proper inclusion.

  • New Features:
    • Added the new 'Runasapi' map to the maps JSON file.
  • Tests:
    • Included a test for the new 'Runasapi' map.

Copy link
Contributor

sourcery-ai bot commented Jun 30, 2024

Reviewer's Guide by Sourcery

This pull request adds a new map called 'Runasapi' to the maps JSON fixture. The changes include adding the map's name, screenshot URL, gamemodes, location, and country code to the existing list of maps.

File-Level Changes

Files Changes
tests/fixtures/json/maps.json Added the new 'Runasapi' map to the maps JSON fixture.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mascherino - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@TeKrop
Copy link
Owner

TeKrop commented Jul 1, 2024

@Mascherino Thank you for your contribution, everything is OK for me ✅

@TeKrop TeKrop merged commit f9cb0af into TeKrop:main Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants