-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed unsupported big float values #171
Conversation
Reviewer's Guide by SourceryThis pull request addresses the issue of unsupported big float values containing commas. The changes include updating the regex pattern and float conversion logic in the helper function, as well as modifying the test cases to ensure proper handling and readability of large numbers. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TeKrop - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
…ed methods with few possible inputs.
Quality Gate passedIssues Measures |
The stray comma gets you every time. |
Fixed unsupported big float values like this (having a
,
in it) :Summary by Sourcery
Fix parsing of big float values containing commas and update relevant test cases.
Bug Fixes:
Tests: