Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed unsupported big float values #171

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Aug 2, 2024

Fixed unsupported big float values like this (having a , in it) :
image

Summary by Sourcery

Fix parsing of big float values containing commas and update relevant test cases.

Bug Fixes:

  • Fixed parsing of big float values containing commas in the input string.

Tests:

  • Updated test cases to include big float values with commas.

@TeKrop TeKrop added the bug Something isn't working label Aug 2, 2024
@TeKrop TeKrop self-assigned this Aug 2, 2024
Copy link
Contributor

sourcery-ai bot commented Aug 2, 2024

Reviewer's Guide by Sourcery

This pull request addresses the issue of unsupported big float values containing commas. The changes include updating the regex pattern and float conversion logic in the helper function, as well as modifying the test cases to ensure proper handling and readability of large numbers.

File-Level Changes

Files Changes
tests/parsers/test_helpers.py
app/parsers/helpers.py
Enhanced support for parsing large float values with commas by updating both the helper function and corresponding test cases.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

app/parsers/helpers.py Outdated Show resolved Hide resolved
tests/parsers/test_helpers.py Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MatthewSH
Copy link
Contributor

The stray comma gets you every time.

@TeKrop TeKrop merged commit f466a43 into main Aug 2, 2024
3 checks passed
@TeKrop TeKrop deleted the bugfix/float_big_number branch August 2, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants