Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated dependencies to last version #183

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Aug 24, 2024

Summary by Sourcery

Update test files to use the latest pytest syntax by removing parentheses from async decorators and fixture definitions.

Enhancements:

  • Remove parentheses from pytest decorators to align with updated pytest syntax.

Tests:

  • Update test files to use the new pytest decorator syntax without parentheses for async tests.
  • Modify test fixtures to remove unnecessary parentheses in their definitions.

@TeKrop TeKrop added the enhancement New feature or request label Aug 24, 2024
@TeKrop TeKrop self-assigned this Aug 24, 2024
Copy link
Contributor

sourcery-ai bot commented Aug 24, 2024

Reviewer's Guide by Sourcery

This pull request updates the pytest.mark.asyncio decorator usage across multiple test files. The changes remove parentheses from the decorator, changing @pytest.mark.asyncio() to @pytest.mark.asyncio. Additionally, some pytest fixtures have been updated to remove empty parentheses.

File-Level Changes

Change Details Files
Updated pytest.mark.asyncio decorator usage
  • Removed parentheses from @pytest.mark.asyncio() decorator
  • Changed @pytest.mark.asyncio() to @pytest.mark.asyncio
tests/parsers/test_namecard_parser.py
tests/parsers/test_player_parser.py
tests/parsers/test_hero_parser.py
tests/parsers/test_player_career_parser.py
tests/parsers/test_player_stats_summary_parser.py
tests/parsers/test_gamemodes_parser.py
tests/parsers/test_heroes_parser.py
tests/parsers/test_maps_parser.py
tests/parsers/test_roles_parser.py
Updated pytest fixture definitions
  • Removed empty parentheses from @pytest.fixture decorator
tests/commands/test_check_and_delete_parser_cache.py
tests/commands/test_check_and_update_cache.py
tests/common/test_cache_manager.py
tests/commands/test_update_search_data_cache.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

sonarcloud bot commented Aug 24, 2024

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title mentions updating dependencies, but the changes appear to be focused on updating pytest decorators and fixtures. Consider updating the PR title to better reflect the actual changes made.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@TeKrop TeKrop merged commit f9d17e4 into main Aug 24, 2024
3 checks passed
@TeKrop TeKrop deleted the feature/update-packages branch August 24, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant