feat: enhanced async client usage

[TeKrop]

Summary by Sourcery

Enhance the codebase by adopting httpx.AsyncClient for asynchronous HTTP requests across parsers, handlers, and tests. Refactor tests to utilize a shared TestClient fixture for FastAPI route testing, and improve dependency management in the players.py router.

Enhancements:

• Refactor tests to use httpx.AsyncClient instead of overfast_client for HTTP requests.
• Update the NamecardParser, PlayerParser, PlayerCareerParser, PlayerStatsSummaryParser, and HeroParser to accept an httpx.AsyncClient instance for making HTTP requests.
• Modify the check_new_hero.py script to use asynchronous HTTP requests with httpx.AsyncClient.
• Refactor the APIParser and APIRequestHandler classes to use a shared httpx.AsyncClient instance for HTTP requests.
• Introduce dependency injection for common player parameters in the players.py router using Annotated and Depends.

Tests:

• Add a new conftest.py file to provide a TestClient fixture for testing FastAPI routes.
• Update test cases across multiple test files to use the client fixture for making HTTP requests.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request enhances the usage of async clients in the project by introducing a shared httpx.AsyncClient instance and updating the codebase to use it consistently. The changes improve the efficiency of HTTP requests and ensure proper resource management.

File-Level Changes

Change	Details	Files
Introduced a shared httpx.AsyncClient instance	Added an overfast_client attribute to the FastAPI app Created the client in the app's lifespan context manager Updated request handlers to use the shared client Modified parsers to accept the client as a parameter	app/main.py app/handlers/api_request_handler.py app/parsers/generics/api_parser.py app/common/helpers.py
Updated test suite to use the shared client	Created a client fixture in tests/views/conftest.py Modified test cases to use the client fixture Updated mocking of HTTP requests in tests	tests/views/conftest.py tests/views/test_player_career_route.py tests/views/test_search_players_route.py tests/parsers/test_player_parser.py
Refactored overfast_request function	Modified overfast_request to accept a client parameter Removed global overfast_client instance Updated all calls to overfast_request to pass the client	app/common/helpers.py app/parsers/search_data_parser.py app/handlers/search_players_request_handler.py
Updated command scripts to use AsyncClient	Modified check_and_update_cache.py to create and use AsyncClient Updated check_new_hero.py to use AsyncClient Ensured proper closing of AsyncClient in command scripts	app/commands/check_and_update_cache.py app/commands/check_new_hero.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sourcery-ai]

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 1 issue found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}