fix: Update competitive information following Blizzard's latest update

[TeKrop]

This PR updates the competitive information in our application to align with the latest changes made by Blizzard. Following the recent update from Blizzard, several endpoints and data structures have been modified, necessitating adjustments on our end to ensure our application remains functional and up-to-date.

The main changes include updating the competitive roles enumeration to include the 'open' option for Open Queue, adjusting the way we handle code quality checks by consolidating them under the ruff command, and ensuring our HTTP requests to Blizzard's API correctly follow redirects. Additionally, we've introduced a new 'champion' competitive division and made various other minor adjustments and bug fixes to maintain the integrity of our data.

These changes were necessary to maintain compatibility with Blizzard's API and to ensure our application provides accurate and current information. While this approach addresses the immediate issues caused by the update, we should remain vigilant for any further changes from Blizzard and be prepared to make additional adjustments as needed.

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[sourcery-ai]

This automated comment suggests enhancements to the PR title and body to improve clarity and facilitate a quicker review

Title suggestion

Update competitive information following Blizzard's latest update

Reasons to update the title

• Consider making the title more concise and focused on the main change
• Use imperative mood for clarity

Body suggestion

This PR updates the competitive information in our application to align with the latest changes made by Blizzard. Following the recent update from Blizzard, several endpoints and data structures have been modified, necessitating adjustments on our end to ensure our application remains functional and up-to-date.

The main changes include updating the competitive roles enumeration to include the 'open' option for Open Queue, adjusting the way we handle code quality checks by consolidating them under the `ruff` command, and ensuring our HTTP requests to Blizzard's API correctly follow redirects. Additionally, we've introduced a new 'champion' competitive division and made various other minor adjustments and bug fixes to maintain the integrity of our data.

These changes were necessary to maintain compatibility with Blizzard's API and to ensure our application provides accurate and current information. While this approach addresses the immediate issues caused by the update, we should remain vigilant for any further changes from Blizzard and be prepared to make additional adjustments as needed.

Reasons to update the body

• Include a brief description of the problem being solved
• Explain why this approach was chosen
• Mention any limitations or considerations for future development
• Provide context or links to relevant discussions or issues, if applicable

---

Benefits of a great title and description

Author benefits

• Faster Approval Times: Clear descriptions lead to quicker, more efficient code review processes.
• Higher Quality Reviews: Well-crafted descriptions lead to more insightful feedback, improving the overall quality of the code.
• Easier Future Maintenance: Simplifies debugging and updating code by providing context and rationale.

Reviewer benefits

• Efficient Review Process: Concise, informative descriptions enable quicker understanding and assessment of changes.
• Improved Decision-Making: Detailed context aids in evaluating the impact and necessity of the change.
• Facilitates Knowledge Sharing: Offers insights into codebase evolution, design choices, and problem-solving approaches.

Guide: Writing good PR descriptions - Google

[sourcery-ai]

PR Type: Enhancement

PR Summary: This pull request addresses updates and enhancements following a Blizzard update, focusing on updating competitive information and refining the codebase. It includes changes to model definitions, parsing logic, and the removal of the player privacy field, reflecting a shift in how player data is handled. Additionally, the PR introduces a new CompetitiveRole enum to better categorize player ranks and updates various helper functions to align with these changes. Code quality improvements are also made by consolidating formatting and linting tools.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.

• Sourcery currently only approves 'Typo fix' PRs.

✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.

No details provided.

📝 Complexity: the changes are too large or complex for Sourcery to approve.

• Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

• Ensure that the removal of the player privacy field is compliant with any data handling and privacy requirements.
• Verify that the new CompetitiveRole enum and the separation of rank and tier icons enhance the data model without introducing redundancy or confusion.
• Consider the impact of these changes on the frontend or any consuming services, especially regarding the removal of privacy filters and the introduction of new competitive rank fields.
• Review the consolidation of code formatting and linting tools for any potential impact on the development workflow or code quality checks.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

• X
• Mastodon
• LinkedIn
• Facebook

---

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.