feat: 홈 화면 캐릭터 만들기 버튼 모바일 최적화 (#19) - #22
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces safe-area inset support for iOS devices by adding viewport-fit=cover to the viewport meta tag and defining a .pb-safe utility class in CSS to replace static bottom padding on the home page. The reviewer provided valuable feedback pointing out that using max(2rem, env(safe-area-inset-bottom)) fails to properly stack the safe-area inset on top of the desired padding, suggesting a cleaner approach using calc(2rem + env(safe-area-inset-bottom)) along with a fallback for older environments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
💡 PR 요약
closes #19
📋 작업 내용
index.htmlviewport-fit=cover추가env(safe-area-inset-bottom)CSS 변수가 실제 값을 반환하려면 이 설정이 필수src/app/index.css.pb-safe유틸리티 클래스 추가src/pages/home/index.tsx🤝 리뷰 시 참고사항