Skip to content

feat: 환경변수로 스타일 선택 단계 ON/OFF 분기 (#20) - #23

Merged
koreahghg merged 5 commits into
developfrom
feat/single-style
Jun 15, 2026
Merged

feat: 환경변수로 스타일 선택 단계 ON/OFF 분기 (#20)#23
koreahghg merged 5 commits into
developfrom
feat/single-style

Conversation

@koreahghg

Copy link
Copy Markdown
Member

💡 PR 요약

closes #20

  • VITE_SINGLE_STYLE 환경변수로 스타일 선택 단계를 켜고 끌 수 있도록 분기 처리

📋 작업 내용

VITE_SINGLE_STYLE=false (기본값) — 기존 4단계 플로우 유지

닉네임 → 스타일 선택 → 인구통계 → 사진

VITE_SINGLE_STYLE=true — 단일 스타일(디즈니풍) 고정 3단계 플로우

닉네임 → 인구통계 → 사진

변경 파일:

  • src/pages/create/index.tsx — 모듈 최상단 상수로 분기, 단계 수/렌더링/유효성 검사 모두 env에 따라 결정
  • src/features/avatar-result/useAvatarResult.ts — style 파라미터 기본 fallback을 ghiblidisney로 변경
  • .envVITE_SINGLE_STYLE=false 추가 (단일 진실 공급원)
  • .env.development — 중복 선언 제거 (.env가 우선순위 적용되도록)

🤝 리뷰 시 참고사항

  • .env.developmentVITE_SINGLE_STYLE을 두면 .env보다 우선순위가 높아 덮어쓰기 때문에 .env 단일 관리로 통일했습니다.
  • Vite는 .env 변경 시 dev 서버 재시작이 필요합니다 (npm run dev).
  • 추후 스타일 선택 단계를 완전히 제거하기로 결정되면 SINGLE_STYLE 분기를 걷어내고 StepStyle 컴포넌트를 삭제하면 됩니다.

@koreahghg
koreahghg requested a review from g-hyxn June 15, 2026 02:21
@koreahghg koreahghg self-assigned this Jun 15, 2026
@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aikon Ready Ready Preview, Comment Jun 15, 2026 2:33am

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a single-style mode controlled by the VITE_SINGLE_STYLE environment variable. When enabled, it skips the style selection step in the avatar creation flow, defaulting the style to 'disney' and adjusting the total steps and validation logic accordingly. It also updates the default style in useAvatarResult to 'disney' and includes package lock updates. The reviewer identified a configuration issue in .env.development where VITE_SINGLE_STYLE is defined twice with conflicting values (both false and true), which should be resolved by keeping only one default value.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .env.development Outdated
@koreahghg
koreahghg merged commit 7d68061 into develop Jun 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants