-
Notifications
You must be signed in to change notification settings - Fork 0
[WIP] SearchInput 컴포넌트 구현 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bangdayeon
wants to merge
1
commit into
main
Choose a base branch
from
feature/#69-add-searchinput-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /* eslint-disable @next/next/no-img-element */ | ||
| import React from "react"; | ||
|
|
||
| type ImageProps = React.ImgHTMLAttributes<HTMLImageElement> & { | ||
| src: string; | ||
| alt: string; | ||
| }; | ||
|
|
||
| /** | ||
| * 테스트용 Image 컴포넌트 | ||
| * - src는 필수 | ||
| * - alt 기본값은 빈 문자열 | ||
| */ | ||
| export default function Image({ src, alt = "", ...rest }: ImageProps) { | ||
| return <img src={src} alt={alt} {...rest} />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| 'use client'; | ||
|
|
||
| import IconButton from '@/components/basics/IconButton/IconButton'; | ||
| import clsx from 'clsx'; | ||
| import React from 'react'; | ||
|
|
||
| import CustomImage from '../../Icons/CustomImage'; | ||
|
|
||
| interface SearchInputProps { | ||
| value: string; | ||
| onChange: (e: React.ChangeEvent<HTMLInputElement>) => void; | ||
| onSubmit: (e: React.FormEvent) => void; | ||
| placeholder?: string; | ||
| size?: 'md' | 'lg'; | ||
| } | ||
|
|
||
| export default function SearchInput({ | ||
| value, | ||
| onChange, | ||
| onSubmit, | ||
| placeholder = '검색하세요', | ||
| size = 'md', | ||
| }: SearchInputProps) { | ||
| const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => { | ||
| e.preventDefault(); | ||
| onSubmit(e); | ||
| }; | ||
|
|
||
| const baseStyle = | ||
| 'flex justify-between pl-4 h-10 text-gray-800 bg-white placeholder-gray-400 rounded-full'; | ||
| const sizes = { | ||
| md: 'w-70', | ||
| lg: 'w-full', | ||
| }; | ||
| const classes = clsx(baseStyle, sizes[size]); | ||
|
Comment on lines
+29
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major 하드코딩된 스타일을 props로 제어 가능하게 리팩토링 필요.
🤖 Prompt for AI Agents |
||
|
|
||
| return ( | ||
| <form onSubmit={handleSubmit} className={classes}> | ||
| <CustomImage src="file.svg" alt="img" /> | ||
| <input | ||
| type="text" | ||
| value={value} | ||
| onChange={onChange} | ||
| placeholder={placeholder} | ||
| className="ml-1 flex-1 bg-transparent outline-none" | ||
| /> | ||
| <IconButton icon="IC_Chat" ariaLabel="search button" /> | ||
| </form> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // SearchInput.stories.tsx | ||
| import SearchInput from '@/components/wrappers/SearchInput/SearchInput'; | ||
| import type { Meta, StoryObj } from '@storybook/react'; | ||
| import React, { useState } from 'react'; | ||
|
|
||
| const meta = { | ||
| title: 'Components/SearchInput', | ||
| component: SearchInput, | ||
| tags: ['autodocs'], | ||
| argTypes: { | ||
| size: { | ||
| control: { type: 'select' }, | ||
| options: ['md', 'lg'], | ||
| }, | ||
| }, | ||
| } satisfies Meta<typeof SearchInput>; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof SearchInput>; | ||
|
|
||
| function ControlledSearchInput( | ||
| args: typeof SearchInput extends React.ComponentType<infer P> ? P : never | ||
| ) { | ||
| const [value, setValue] = useState(''); | ||
|
|
||
| return ( | ||
| <SearchInput | ||
| {...args} | ||
| value={value} | ||
| onChange={e => setValue(e.target.value)} | ||
| onSubmit={e => { | ||
| e.preventDefault(); | ||
| console.log('Submit:', value); | ||
| }} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| export const Default: Story = { | ||
| render: args => <ControlledSearchInput {...args} />, | ||
| args: { | ||
| placeholder: '검색하세요', | ||
| size: 'md', | ||
| }, | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이슈 요구사항과 props 미스매치(size, radius, variant, icon).
Linked issue(#69)에 정의된
radius,variant,icon이 누락되었습니다. 재사용성을 위해 API를 정합화하세요(현 PR에 포함하거나 후속 PR로 트래킹).간단한 방향:
radius?: 'none'|'sm'|'md'|'lg'|'full'→ 클래스 매핑variant?: 'classic'|'surface'|'soft'→ 배경/테두리 클래스 매핑leftIcon?: React.ReactNode,submitIcon?: React.ReactNode→ 현재 하드코딩된 SVG 대체원하시면 최소 구현 패치(diff) 제안 드리겠습니다.
🤖 Prompt for AI Agents