Merged
Conversation
rtttr1
reviewed
Mar 14, 2025
Contributor
rtttr1
left a comment
rtttr1
left a comment
There was a problem hiding this comment.
고생하셨습니다~~!!!!! 가벼운 코멘트 한번 확인해주세요~
| export const MAX_TEAM_COUNT = 8; | ||
| export const MAX_TEAM_COUNT = 8 as const; | ||
|
|
||
| export const MAX_TEAM_NAME = 30 as const; |
Contributor
There was a problem hiding this comment.
as const를 선언하는 이유가 const로 선언한 객체의 프로퍼티의 값까지 상수화하여 타입으로 활용하고자 할 떄 사용하는 것으로 아는데 Number 원시값에 사용한 이유가 있으실까요?
Member
Author
There was a problem hiding this comment.
앗 별다른 이유 없었습니다 수정할게요 !!
| const [inputValue, setInputValue] = useState(formData.name); | ||
|
|
||
| const isDisabled = inputValue.trim().length === 0; | ||
| const isNameError = inputValue.length > MAX_TEAM_NAME; |
Contributor
There was a problem hiding this comment.
isNameLengthError 로 하면 변수명이 길어지긴 하지만 좀 더 직관적일 수도 있겠네요~
Bowoon1216
approved these changes
Mar 15, 2025
| URL.revokeObjectURL(newFileURL); | ||
| }, | ||
| onError: (error) => { | ||
| console.error(error); |
Member
Author
There was a problem hiding this comment.
에러 발생할 때 찍어주는 콘솔이라서 유지하겠슴니당 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #497
체크리스트
💎 PR Point
워크스페이스 생성 모달 큐에이 진행했습니다
모달의 마지막 단계에 (complete) 업로드한 이미지를 보여줘야 하는데 이미지 url을 전달하면 자꾸 엑박이 떠서..
일단 onError 속성 사용해서 띄워줬습니다. 시간 생기는대로 해결해볼게요
SNB에는 정상적으로 뜹니다
엑박 이슈는 다음 브랜치에서 진행하겠습니다
📌스크린샷 (선택)