added flashyflash #111
Open
added flashyflash #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amikhalev
previously requested changes
Oct 1, 2016
|
|
||
| private Config config; | ||
| private int times; | ||
| private Timer timer; |
There was a problem hiding this comment.
You are never initializing this. You should be able to get this from robot
|
Forgot to register command |
|
Rename the command class-- there is no auton subsystem |
|
Read the documentation of Timer, it's used wrong here |
vpzomtrrfrt
reviewed
Oct 5, 2016
| boolean blinding = vision.getLedState(); | ||
| if(blinding && timer.hasPeriodElapsed(config.onTime)) { | ||
| vision.setLedState(false); | ||
| timer.reset(); |
There was a problem hiding this comment.
I don't think resetting is necessary if you immediately start again
riftEmber
reviewed
Oct 7, 2016
| super("VisionFlashyFlash"); | ||
| vision = robot.vision(); | ||
| requires(vision); | ||
| this.timer = new Timer(robot.timeProvider()); |
There was a problem hiding this comment.
use robot.timer() even though it isn't merged yet
riftEmber
reviewed
Oct 7, 2016
| logger.info("Flashing light {} times", config.maxTimes); | ||
| times = 0; | ||
| vision.setLedState(true); | ||
| timer.reset(); |
There was a problem hiding this comment.
get rid of redundant timer function calls
riftEmber
reviewed
Oct 7, 2016
|
|
||
| static class Config { | ||
| public int maxTimes; | ||
| public float onTime; |
abbbbbby
force-pushed
the
add-FlashyFlash
branch
2 times, most recently
from
9a156d0 to
d78b628
Compare
vpzomtrrfrt
force-pushed
the
add-FlashyFlash
branch
from
d78b628 to
c578d15
Compare
vpzomtrrfrt
suggested changes
Oct 15, 2016
| boolean blinding = vision.getLedState(); | ||
| if(blinding && timer.hasPeriodElapsed(config.onTime)) { | ||
| vision.setLedState(false); | ||
| timer.start(); |
There was a problem hiding this comment.
Apparently not necessary, hasPeriodElapsed restarts if it has
| super("VisionFlashyFlash"); | ||
| vision = robot.vision(); | ||
| requires(vision); | ||
| timer = new Timer(robot.timeProvider()); |
There was a problem hiding this comment.
Get the timer from robot
abbbbbby
force-pushed
the
add-FlashyFlash
branch
from
7274ada to
1459c18
Compare
|
Needs autoformat |
riftEmber
reviewed
Oct 16, 2016
| private AbstractVision vision; | ||
|
|
||
| public VisionFlashyFlash(CoreRobot robot) { | ||
| super("AutonFlashyFlash"); |
abbbbbby
force-pushed
the
add-FlashyFlash
branch
from
1459c18 to
bd954f7
Compare
riftEmber
force-pushed
the
add-FlashyFlash
branch
from
bd954f7 to
2ea1ac7
Compare
riftEmber
force-pushed
the
add-FlashyFlash
branch
from
2ea1ac7 to
e17c0d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.