added rumblyrumble #114

abbbbbby · 2016-10-01T21:39:14Z

No description provided.

riftEmber · 2016-10-01T22:40:03Z

Forgot to register command

riftEmber · 2016-10-02T19:26:38Z

Fix usage of Timer here too

riftEmber · 2016-10-02T19:31:27Z

core/src/main/java/org/teamtators/rotator/commands/RumblyRumble.java

+
+    private Config config;
+    private int times;
+    private Timer timer;


not initialized

amikhalev · 2016-10-03T15:41:42Z

core/src/main/java/org/teamtators/rotator/commands/RumblyRumble.java

+import org.teamtators.rotator.operatorInterface.LogitechF310;
+import org.teamtators.rotator.operatorInterface.RumbleType;
+
+public class RumblyRumble extends CommandBase implements Configurable<RumblyRumble.Config> {


Maybe just call this OIRumble or JoystickRumble

amikhalev · 2016-10-03T15:42:11Z

rio/src/main/java/org/teamtators/rotator/operatorInterface/WPILibLogitechF310.java

+            case LEFT:
+                setRumble(RumbleType.kLeftRumble, value);
+                break;
+            case RIGHT:


riftEmber · 2016-10-03T18:15:36Z

Do we want a logger?

riftEmber · 2016-10-07T02:51:51Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+
+    static class Config {
+        public int maxTimes;
+        public float onTime;


you're in double territory now and you better act like it

riftEmber · 2016-10-08T20:33:24Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    @Override
+    public void configure(OIRumble.Config config) {
+        this.config = config;
+        timer = robot.timer();


This should be created in the constructor. In this scope there isn't even a "robot"

riftEmber · 2016-10-08T20:33:37Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    private boolean rumbling;
+
+    public OIRumble(CoreRobot robot) {
+        super("RumblyRumble");


Should have the same name as the command

riftEmber · 2016-10-08T20:34:14Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    }
+
+    @Override
+    public void configure(OIRumble.Config config) {


I don't think you need to specify that it's an OIRumble.Config, just Config should work

riftEmber · 2016-10-08T20:35:35Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+        public int maxTimes;
+        public double onTime;
+        public double offTime;
+        public LogitechF310 joystick;


How does one specify a LogitechF310 in config? This should probably just be name of the joystick, and then you can get the right one in configure

riftEmber · 2016-10-08T20:36:11Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+        logger.info("Rumbling {} times", config.maxTimes);
+        times = 0;
+        config.joystick.setRumble(config.type, config.value);
+        rumbling = false;


You're setting rumbling to false after starting it rumbling on the line before

riftEmber · 2016-10-08T20:36:43Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    @Override
+    protected boolean step() {
+        if(rumbling && timer.hasPeriodElapsed(config.onTime)) {
+            config.joystick.setRumble(config.type, 0.0f);


riftEmber · 2016-10-08T20:36:51Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    }
+
+    protected void finish() {
+        config.joystick.setRumble(config.type, 0.0f);


also just a 0 here works

riftEmber · 2016-10-08T20:42:20Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+        if(rumbling && timer.hasPeriodElapsed(config.onTime)) {
+            config.joystick.setRumble(config.type, 0.0f);
+            rumbling = false;
+            times ++;


Autoformat all your files

It appears to be dealt with

vpzomtrrfrt · 2016-10-15T02:45:50Z

Appears to depend on #119

vpzomtrrfrt · 2016-10-15T21:39:02Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    @Override
+    public void configure(Config config) {
+        this.config = config;
+        if (config.joystick == "driver") {


Once #121 is merged, this should use that

riftEmber · 2016-10-16T18:53:46Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    private AbstractOperatorInterface operatorInterface;
+
+    public OIRumble(CoreRobot robot) {
+        super("IORumble");


riftEmber · 2016-10-16T18:55:07Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+    @Override
+    public void configure(Config config) {
+        this.config = config;
+        if (config.joystick == "driver") {


should use .equals() method, not ==

riftEmber · 2016-10-16T18:55:15Z

core/src/main/java/org/teamtators/rotator/commands/OIRumble.java

+        this.config = config;
+        if (config.joystick == "driver") {
+            joystick = operatorInterface.driverJoystick();
+        } else if (config.joystick == "gunner") {


And what if they ask for a joystick that doesn't exist?

riftEmber reviewed Oct 2, 2016

View reviewed changes

amikhalev requested changes Oct 3, 2016

View reviewed changes

riftEmber added the command label Oct 5, 2016

abbbbbby force-pushed the add-rumblyrumble branch from fc9af7a to 7214f33 Compare October 7, 2016 02:18

riftEmber reviewed Oct 7, 2016

View reviewed changes

abbbbbby force-pushed the add-rumblyrumble branch 2 times, most recently from 2b3cf4d to bdc828d Compare October 7, 2016 02:53

riftEmber previously requested changes Oct 8, 2016

View reviewed changes

abbbbbby force-pushed the add-rumblyrumble branch from bdc828d to e771a5a Compare October 8, 2016 21:04

vpzomtrrfrt reviewed Oct 15, 2016

View reviewed changes

riftEmber reviewed Oct 16, 2016

View reviewed changes

abbbbbby force-pushed the add-rumblyrumble branch 2 times, most recently from 82707e4 to ce994bf Compare October 18, 2016 01:35

added rumblyrumble

bb6e316

abbbbbby force-pushed the add-rumblyrumble branch from ce994bf to bb6e316 Compare October 18, 2016 01:35

added rumblyrumble #114

Are you sure you want to change the base?

added rumblyrumble #114

Uh oh!

Conversation

abbbbbby commented Oct 1, 2016

Uh oh!

riftEmber commented Oct 1, 2016

Uh oh!

riftEmber commented Oct 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riftEmber commented Oct 3, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riftEmber Oct 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vpzomtrrfrt commented Oct 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

riftEmber Oct 8, 2016 •

edited

Loading