-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1 [09.01.2022] #451
Open
ghost
wants to merge
23
commits into
dev
Choose a base branch
from
master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#1 [09.01.2022] #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bring back modpack icon; - Fix missing ae2 recipes; - Lang missings for mocolors; - Bring back wood to old wood chest switch in crafting table.
- Add missing buttons texture - Delete unnecessary scripts (Wood & Mires are fixed by author 397 days ago) Cant fix more today because gdlauncher prevents me from installing the modpack.
Author forgot to extend the call recipes with different planks.
- I was able to install the modpack, the icons looked so tragic that I had to correct them. After that I'm moved them to properly folder; - Related to aof5 changed the color of the loading bar; - Add missing lang files, more to come.
- removed duplicates and wrong banners; - add social_interactions texture; - delete pl_pl from flonter folder assets in kubejs (I added it accidentally from my library).
- Add missing GUI textures; I do not remember where I added them, if it does not load, you have to search in the modmenu assets and change the place.
- Add conjurer blacklist; Trent87 added it and you deleted it. Additionally, consider restoring cloth-config-4.11.26-fabric instead of cloth-config-4.12.41-fabric. (rei goes crazy with the newer version)
- Add missing tag + hide lucernia table in rei; - Add missing lang files; - Add recipe to obtain leather from rotten_flesh; Additional; consider adding animals banners to your entity_banner blacklist. Player should not receive a reward for killing innocent, helpless animals degenerate
additional commit: - Add qol recipes script; - Add egg recipes; bonus to encourage players to collect items and use them to craft eggs, due to the fact that this is my old script, it does not contain bugs but it certainly contains mod items that your modpack does not have.
additional commit: - Add more difficult kibe recipes + additional options to craft magnet; - add additional options to craft wooden_hoppers I hope that you will introduce some of these changes and you will not abandon these updates as recently when I sent you all these patches in a private message on discord. Don't look for it anymore, I deleted this message 24 hours after sending, claiming you are a beetroot. As I remember what else is missing and what is broken, I will add another pr. I hope you & your team like it.
#1 [09.01.2022]
inadvertence
repair mistakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cssmc/All-of-Fabric-3/commit/635ce905a6b26450668da36d815d7c1163821843