Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change type of characterId from string to number #91

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

MustSave
Copy link
Contributor

PR 제목

PR을 한 이유 🎯

  • 캐릭터 id의 타입을 string -> int 변경

이슈 번호 📎

  • (해결하고자 하는 이슈의 이름과 해시태그 번호를 적어주세요. 예: 이슈명 #123)

변경사항 🛠

  • 캐릭터 id의 타입을 string -> int 변경

특이사항 📌

  • 기존 레거시 코드가 꽤가 있어 일부만 변경하였음.

테스트 결과 📝

  • 로컬에서 채팅서버에 채팅 하였을 때 정상 동작.

@soulchicken
Copy link
Member

룩 굿 투 미

@MustSave MustSave merged commit 645dd67 into develop Oct 12, 2023
@MustSave MustSave deleted the fix/change-characterid-type branch October 12, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants