[KW-455] feat: building grpc server 추가#30
Merged
coffeesigma merged 1 commit intodevelopfrom May 26, 2025
Hidden character warning
The head ref may contain hidden characters: "KW-455/feat/building-grpc-\ucd94\uac00"
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a building gRPC server implementation to support building-related requests.
- Adds BuildingGrpcServiceImpl for handling getBuildingById requests.
- Integrates repository lookup and error handling via CommonException with a BuildingErrorCode.
Comments suppressed due to low confidence (1)
src/main/java/com/doubleo/hospitalservice/domain/building/grpc/server/BuildingGrpcServiceImpl.java:25
- [nitpick] Consider extracting the building-to-response mapping logic into a separate private method for improved maintainability and reusability, especially if similar mapping logic is used elsewhere.
BuildingResponse resp = BuildingResponse.newBuilder()
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-455
📌 작업 내용 및 특이사항
📚 참고사항