[KW-553] fix: fcm 토큰 없을때 null error 나지 않도록 수정#22
Merged
coffeesigma merged 1 commit intodevelopfrom May 31, 2025
Merged
Conversation
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a null error issue when the FCM token is absent by using Optional to safely default to an empty string. Key changes include:
- Importing java.util.Optional.
- Updating the FCM token assignment to avoid null values.
- Ensuring the gRPC response is built without null errors.
Comments suppressed due to low confidence (1)
src/main/java/com/doubleo/memberservice/domain/member/grpc/server/MemberGrpcServiceImpl.java:33
- While using Optional to default to an empty string resolves the null error, please verify that an empty string is the appropriate default for downstream processing to avoid unintended behavior.
Optional.ofNullable(res.getFcmToken())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-553
📌 작업 내용 및 특이사항
📚 참고사항