feat: read monitors from config file#19
Merged
Mivik merged 4 commits intoTeamFlos:mainfrom Feb 4, 2025
Merged
Conversation
YuevUwU
reviewed
Feb 4, 2026
Comment on lines
+120
to
+123
| let config: ServerConfig = File::open("server_config.yml") | ||
| .ok() | ||
| .and_then(|f| serde_yaml::from_reader(f).ok()) | ||
| .unwrap_or_default(); |
Contributor
There was a problem hiding this comment.
WARNING: Ignore Too Broad Errors
io::Error and serde_yaml::Error are ignored without any message, and then rollback to use the default vec![2].
This will cause allowed users other than Mivik to inexplicably find themselves unable to monitor when attempting to monitor the system.
Fix: #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid unnecessary cost when changing monitors.