Skip to content

fix: Fake notes should not have fade out effects #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mivik merged 2 commits into from
Mar 27, 2026
+3 −2
Merged

fix: Fake notes should not have fade out effects #720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aa22bb
fix: Fake notes should not have fade out effects
NuanRMxi Mar 26, 2026
b6b4a20
Update prpr/src/core/note.rs
Mivik Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions prpr/src/core/note.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ impl Note {
};

if !config.draw_below
&& ((res.time - FADEOUT_TIME >= self.time && !matches!(self.kind, NoteKind::Hold { .. }))
&& (((res.time - FADEOUT_TIME >= self.time || (self.fake && res.time >= self.time)) && !matches!(self.kind, NoteKind::Hold { .. }))
|| (self.time > res.time && cover_base <= -0.001))
{
return;
Expand All @@ -255,7 +255,8 @@ impl Note {
let draw = |res: &mut Resource, tex: Texture2D| {
let mut color = color;
if !config.draw_below {
color.a *= (self.time - res.time).min(0.) / FADEOUT_TIME + 1.;
let alpha = (self.time - res.time).min(0.) / FADEOUT_TIME + 1.;
color.a *= if self.fake && res.time >= self.time { 0. } else { alpha };
}
color.a *= mod_alpha;
res.with_model(self.now_transform(res, ctrl_obj, base, config.incline_sin), |res| {
Expand Down
Loading