stencil outline test #395
Draft
stencil outline test #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
force-pushed
the
feature/test-code-stencil-outline
branch
from
6476f2d to
5c3fe45
Compare
velzie
reviewed
Sep 17, 2024
source/qcommon/common.c
Outdated
| @@ -230,6 +230,7 @@ void Com_Printf( const char *format, ... ) | |||
| Q_vsnprintfz( msg, sizeof( msg ), format, argptr ); | |||
| va_end( argptr ); | |||
|
|
|||
| printf("%s", msg); | |||
There was a problem hiding this comment.
ah this probably wasn't supposed to get committed?.. although maybe we should have a flag for enabling console output ?
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feature/test-code-stencil-outline
branch
from
d497beb to
994ef7a
Compare
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feature/test-code-stencil-outline
branch
from
404d54d to
84b16ad
Compare
Signed-off-by: Michael Pollind <[email protected]>
|
umm seems like there are problems on some machines with this. umm I feel like maybe i rather do this in the NRI branch. |
|
yeah i think it's fine if it ends up being nri exclusive. whatever is easier to write and maintain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://www.youtube.com/watch?v=wrPPWuwIgnc