Skip to content

Guard kinetic damage networking to server-side#175

Merged
PssbleTrngle merged 2 commits intoTeamGalena:1.20.xfrom
lawrencexli:fix/kineticdamage-serveronly
Mar 3, 2026
Merged

Guard kinetic damage networking to server-side#175
PssbleTrngle merged 2 commits intoTeamGalena:1.20.xfrom
lawrencexli:fix/kineticdamage-serveronly

Conversation

@lawrencexli
Copy link

Addressing a client crash that can occur on dedicated servers when KineticDamage.apply() is invoked on the client, causing NullPointerException due to PacketDistributor being called client-side instead of server-side.

@lawrencexli
Copy link
Author

Tested on Forge 1.20.1 with Oreganized mod and Cataclysm mod.

Steps:

  1. Setup a dedicated 1.20.1 Forge server with Oreganized mod and Cataclysm mod (latest version), turn pvp off in server.properties.
  2. Join server with 2 players
  3. Try using Cataclysm weapon to attack other player.

Before: Client crash (crash-2026-02-22_17.20.56-client.txt)

After: No client crash.

@lawrencexli
Copy link
Author

Possibly addressing the Kinetic Damage crash on server client side with bettercombat installed issue.

@PssbleTrngle
Copy link
Member

thank you very much

@PssbleTrngle PssbleTrngle self-requested a review March 3, 2026 18:21
@PssbleTrngle PssbleTrngle merged commit 3c3b37e into TeamGalena:1.20.x Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants