Cleaning up device interface #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the discussion on TeamGraphix#230, there was a comment about improving the device interface implementation (see TeamGraphix#230 (comment) ). In particular, I removed the `except Exception` path, being unable to reproduce an example where this path is reached. If we want to handle some errors (such as `TranspilerError`?), we should be more specific.
This was referenced Jan 6, 2025
Closed
shinich1
reviewed
Jan 14, 2025
| kwargs_get_backend["instance"] = instance | ||
| if resource is not None: | ||
| kwargs_get_backend["resource"] = resource | ||
| self.backend.get_backend(**kwargs_get_backend) |
There was a problem hiding this comment.
note: interface here is different in the latest commit of graphix-ibmq that is compatible with qiskit 1.0, to be merged soon.
EarlMilktea
reviewed
Jan 25, 2025
| @@ -17,7 +17,7 @@ class PatternRunner: | |||
| Executes the measurement pattern. | |||
| """ | |||
|
|
|||
| def __init__(self, pattern: Pattern, backend: str = "ibmq", **kwargs) -> None: | |||
| def __init__(self, pattern: Pattern, backend: str = "ibmq", instance: str | None = None, resource: str | None = None, save_statevector: bool = False, optimizer_level: int = 1, shots: int = 1024) -> None: | |||
There was a problem hiding this comment.
This update sadly does not contribute to type-stable interface (better than **kwargs though).
My ideas:
- define ABC for backends
- remove
= "ibmq": we do not need to add information about the name of the class inheritingABC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussion on #230, there was a comment about improving the device interface implementation (see
#230 (comment) ).
In particular, I removed the
except Exceptionpath, being unable to reproduce an example where this path is reached. If we want to handle some errors (such asTranspilerError?), we should be more specific.