Skip to content

Commit

Permalink
Update version to 0.19.8 (953)
Browse files Browse the repository at this point in the history
Update extractot version.
Fix extraction of YouTube's decryption function.
  • Loading branch information
TobiGr committed Jul 27, 2020
1 parent d6d8c78 commit 7918e3a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ android {
resValue "string", "app_name", "NewPipe"
minSdkVersion 19
targetSdkVersion 29
versionCode 952
versionName "0.19.7"
versionCode 953
versionName "0.19.8"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables.useSupportLibrary = true
Expand Down Expand Up @@ -163,7 +163,7 @@ dependencies {
exclude module: 'support-annotations'
}

implementation 'com.github.TeamNewPipe:NewPipeExtractor:b4481dfec21cf39aabbb791290d30130235aeabd'
implementation 'com.github.TeamNewPipe:NewPipeExtractor:5ac80624a40f4c600ae493e66881b5bf008f0ddb'

implementation "com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751"
implementation "org.jsoup:jsoup:1.13.1"
Expand Down
1 change: 1 addition & 0 deletions fastlane/metadata/android/en-US/changelogs/953.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix extraction of YouTube's decryption function.

10 comments on commit 7918e3a

@vdbhb59
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to the old. Does not play anything at all. No matter what I do. Tried in 5 different phones, and on 2 android TV. Download too does not work.
0.19.8 FDroid version.

@wb9688
Copy link
Contributor

@wb9688 wb9688 commented on 7918e3a Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdbhb59: What error are you getting?

@vdbhb59
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20200731-181858_NewPipe

@vdbhb59
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No error. It keeps buffering like this for ever. This was not the case earlier.

@Stypox
Copy link
Member

@Stypox Stypox commented on 7918e3a Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change quality, see #2415

@vdbhb59
Copy link

@vdbhb59 vdbhb59 commented on 7918e3a Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried all qualities. Tried VPN, tried without VPN, mobile data, WiFi, hotspot. Still infinite buffering.
Ohh and it is for all videos, irrespective of channel, or playlist or individual video.

@Stypox
Copy link
Member

@Stypox Stypox commented on 7918e3a Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wb9688 could you provide him the Chrome HAR generation apk?

@wb9688
Copy link
Contributor

@wb9688 wb9688 commented on 7918e3a Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stypox: Every debug APK has that, so just link the one at the end of the issue that was pinned and fixed in v0.19.8. However this looks like the DASH bug.

@Stypox
Copy link
Member

@Stypox Stypox commented on 7918e3a Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but... with every video and on multiple devices? This seems like a different issue

@Stypox
Copy link
Member

@Stypox Stypox commented on 7918e3a Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you install https://wb9688.stackstorage.com/s/eBfTmrxPUsGTNGAx, connect your phone to your PC through USB, open Chrome, go to chrome://inspect, open that debug version of NewPipe on your phone, select that NewPipe instance in Chrome, go to the Network tab, try to reproduce the issue using that video, and once you've successfully reproduced the issue, right-click in Chrome, select "Save as HAR with Content" and send me that HAR? Then I might be able to fix this issue.
@vdbhb59 please do this and open an issue when done

Please sign in to comment.